-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to go 1.13 #372
Upgrade to go 1.13 #372
Changes from 5 commits
ab74175
e26b280
8f8ad2d
bdb59be
c70610f
629171b
a26a352
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1.11.5 | ||
1.13.8 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,9 +8,9 @@ import ( | |
"testing" | ||
|
||
"github.com/google/go-github/v29/github" | ||
"github.com/hashicorp/terraform/helper/acctest" | ||
"github.com/hashicorp/terraform/helper/resource" | ||
"github.com/hashicorp/terraform/terraform" | ||
"github.com/hashicorp/terraform-plugin-sdk/helper/acctest" | ||
"github.com/hashicorp/terraform-plugin-sdk/helper/resource" | ||
"github.com/hashicorp/terraform-plugin-sdk/terraform" | ||
"github.com/kylelemons/godebug/pretty" | ||
) | ||
|
||
|
@@ -77,7 +77,7 @@ func TestAccGithubBranchProtection_users(t *testing.T) { | |
rString := acctest.RandString(5) | ||
repoName := fmt.Sprintf("tf-acc-test-branch-prot-%s", rString) | ||
|
||
resource.Test(t, resource.TestCase{ | ||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testAccGithubBranchProtectionDestroy, | ||
|
@@ -95,10 +95,6 @@ func TestAccGithubBranchProtection_users(t *testing.T) { | |
resource.TestCheckResourceAttr(rn, "restrictions.0.users.#", "1"), | ||
), | ||
}, | ||
{ | ||
Config: testAccGithubBranchProtectionConfigUser(repoName, "user_with_underscore"), | ||
ExpectError: regexp.MustCompile("unable to add users in restrictions: user_with_underscore"), | ||
}, | ||
{ | ||
ResourceName: rn, | ||
ImportState: true, | ||
|
@@ -108,9 +104,6 @@ func TestAccGithubBranchProtection_users(t *testing.T) { | |
}) | ||
} | ||
|
||
/* TODO: Research what's going on with this restrictions bug in the API | ||
that started 2 Aug '19. No changes were made before the error started | ||
*/ | ||
func TestAccGithubBranchProtection_teams(t *testing.T) { | ||
var firstP, secondP, thirdP github.Protection | ||
|
||
|
@@ -480,7 +473,7 @@ resource "github_team" "first" { | |
resource "github_team_repository" "first" { | ||
team_id = "${github_team.first.id}" | ||
repository = "${github_repository.test.name}" | ||
permission = "pull" | ||
permission = "push" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a bit more context around this change? I'm curious how this helps to get the test passing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to GitHub API docs - The restrictions object has the following keys: |
||
} | ||
|
||
resource "github_team" "second" { | ||
|
@@ -490,7 +483,7 @@ resource "github_team" "second" { | |
resource "github_team_repository" "second" { | ||
team_id = "${github_team.second.id}" | ||
repository = "${github_repository.test.name}" | ||
permission = "pull" | ||
permission = "push" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a bit more context around this change? I'm curious how this helps to get the test passing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to GitHub API docs - The restrictions object has the following keys: |
||
} | ||
|
||
resource "github_branch_protection" "master" { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a bit more context around this change? I'm curious how this helps to get the test passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unintended change, I thought TLS issues were due to parallelization, reverting to original.