Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTeamAndUserFromURL function #326

Closed

Conversation

steakfest
Copy link

The github api started returning a different url format, this handles both the old and new string, just in case they change it back.

The github api started returning a different url format, this handles both the old and new string, just in case they change it back.
@ghost ghost added the size/XS label Jan 17, 2020
@steakfest
Copy link
Author

This is a possible alternative to https://github.com/terraform-providers/terraform-provider-github/pull/325

This seems like a less intrusive way of changing the behavior of the provider. Keeping the original intent of the code and adjusting for the change, safely.

@MichaelMarieJulie
Copy link

Thanks you for this fix, it seems working perfectly
May we know when it can be released as it’s really impactful for everybody ?

@meabed
Copy link

meabed commented Jan 17, 2020

Thanks for the fix! how would you override this directly until the fix is released official ?

@TheKevJames
Copy link

@meabed see the "quick fix" here: https://github.com/terraform-providers/terraform-provider-github/pull/325#issuecomment-575674622 (note that you'll need to change the github invocation if you'd prefer this fix over the other one). You may also need to roll back your state file: https://github.com/terraform-providers/terraform-provider-github/pull/325#issuecomment-575751214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants