Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing the way listOptions is handled so it doesn't error out #2520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jj-scoll
Copy link

…when there are more environments then the max allowed in the request

Resolves #2519


Before the change?

When more than 30 environments exist the data source errors out and the plugin crashes.

After the change?

The plug will parse through the pages of environments instead of crashing

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features) - Not sure how to test automate the test without a live GitHub repo with 30+ environments
  • [x ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

…when there are more environments then the max allowed in the request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant