Fixed incorrect secret creation on drift detection of secret value

[jorgecarleitao]

Resolves #1383
Resolves #2288

---

Before the change?

Given a .tf with a resource with any secret
When .tf is applied
And the secret's value is externally modified
And .tf is applied
Then the new plan results in the creation of a new secret

After the change?

Given a .tf with a resource with any secret
When .tf is applied
And the secret's value is externally modified
And .tf is applied
Then the plan results in the update of the existing secret

In particular, this behavior enables the use of the lifecycle meta argument to ignore changes to externally updated secrets.

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

NOTE: I could not find any test that I could re-use to introduce an external change to an existing resource. Need support.

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[nbali]

yeah, pretty much what I had in mind, ty for your time

[mothilraj]

Please let us know when this fix will be merged.