Fixed renaming if the branch names are identical #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
reviewed
Oct 15, 2024
bateller
approved these changes
Oct 16, 2024
|
@kfcampbell Thank you for your feedback, I was looking through the tests and struggled to understand how to integration test with mock calls to the API. I am familiar with Go but haven't yet done any testing with it. Are you able to provide some pointers as to how I could implement the tests? |
CEbbinghaus
force-pushed
the
CES/FixWrongfulRename
branch
from
85abb4b to
90f3c3e
Compare
|
@kfcampbell Test has been added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1904
Before the change?
Applying a default branch rule on a repository that already has a default branch with the same name returns a http error 422 causing the
tf applyto fail. This is because we call theRenameBranchapi trying to renamemaintomainAfter the change?
We validate that the branch being renamed is different from the current default before we try and rename it
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!