[fix]: Fixed incorrect error handling that led to panic in github_repository_environment
#1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickfloyd PTAL btw, this class of errors can be avoided if "not found" errors are checked up in the stack. I had a webinar on it - https://www.youtube.com/watch?v=KALvN2Yux3U |
Hey @nfx, thanks for the contributions and for the content you linked, I am sure it will help make things better going forward, we'll have a look and reach out if we have any questions! ❤️ |
nickfloyd
approved these changes
Oct 11, 2023
nickfloyd
approved these changes
Oct 11, 2023
nickfloyd
approved these changes
Oct 11, 2023
nickfloyd
changed the title
github_repository_environmentgithub_repository_environment
This was referenced Oct 24, 2023
|
🙏🏽 @nickfloyd @nfx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1931