Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-github to v43.0.0 #1087

Merged
merged 5 commits into from
Apr 8, 2022

Conversation

btkostner
Copy link
Contributor

This PR upgrades go-github to v43.0.0 from the current v42.0.0. Here are the release comments.

This is a prerequisite to fix #1045

It's been years since I've seriously touched go and the package management landscape has changed a lot, so let me know if I missed something or changed something on accident.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I've made the same changes locally and I don't have a diff with your remote. Merging these sorts of PRs is always a bit tricky since they invite merge conflicts, so I'll probably end up cutting a release this Friday for the v4.23.0 milestone and then merging this sometime next week.

@kfcampbell kfcampbell added this to the v4.24.0 milestone Mar 22, 2022
@kfcampbell kfcampbell merged commit 85c5a51 into integrations:main Apr 8, 2022
@btkostner btkostner deleted the upgrade-go-github branch April 8, 2022 19:14
kfcampbell added a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
* upgrade go-github to v43.0.0

* include vendor files

* Fix merge issue that introduced v42 again

Co-authored-by: Keegan Campbell <[email protected]>
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
* upgrade go-github to v43.0.0

* include vendor files

* Fix merge issue that introduced v42 again

Co-authored-by: Keegan Campbell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Add support for 'public' attribute on github pages configuration
2 participants