Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small CI cleanup #1048

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Small CI cleanup #1048

merged 6 commits into from
Jan 27, 2022

Conversation

kfcampbell
Copy link
Member

There's a couple of small fixes to our CI checks I'd like to make:

  • make build was running go install, not go build
  • make test ran a fmtchecker but not our actual unit tests, which are trivial to run
  • Our CONTRIBUTING.md was recommending running unit tests, which we don't really encourage for local development validation
  • tools.go was improperly formatted; not sure why our CI check didn't catch it
  • Removed the -mod=vendor flag
    • In this doc, see the section that reads: "At go 1.14 or higher, automatic vendoring may be enabled. If the file vendor/modules.txt is present and consistent with go.mod, there is no need to explicitly use the -mod=vendor flag."
  • Updated to the most recent version of Go for the Actions runner
    • The project remains low in version and able to be importable by a wide range of Go versions.
    • This should give us quicker build times and smaller binary sizes while retaining backards compatibility.

I also added testdata/ to the .gitignore file based on a personal preference, but I'm happy to revert that if desired.

@kfcampbell kfcampbell requested a review from jcudit January 25, 2022 01:07
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish I could approve it twice 🙇🏾

@kfcampbell kfcampbell merged commit fd0b40c into integrations:main Jan 27, 2022
@kfcampbell kfcampbell deleted the small-ci-cleanup branch January 27, 2022 16:54
kfcampbell added a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants