Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add manual test runs #1026

Merged
merged 6 commits into from
Jan 7, 2022
Merged

test: add manual test runs #1026

merged 6 commits into from
Jan 7, 2022

Conversation

jcudit
Copy link
Contributor

@jcudit jcudit commented Jan 6, 2022

This tunes our acceptance testing in a couple of ways:

  • reduces frequency of automated runs to weekly
  • re-instates a manual option that allows for labels applied to PRs to trigger tests

See https://github.com/jcudit/terraform-provider-github/actions/workflows/dotcom-acceptance-tests-manual.yml for example test runs and jcudit#1 as an example of labelling.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple questions but overall this looks good!

@@ -8,7 +8,7 @@ on:
# │ │ │ ┌───────────── month (1 - 12 or JAN-DEC)
# │ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT)
# * * * * *
- cron: '0 0 * * *'
- cron: '0 0 * * 3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal on this change to save on rate limits? Overall GitHub resources/churn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

.github/workflows/dotcom-acceptance-tests-manual.yml Outdated Show resolved Hide resolved
uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.ref }}
fetch-depth: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what's the reason for fetch-depth: 2 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revisit here with more context, seems architectural though.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This looks great.

@jcudit jcudit merged commit b8c2fdf into integrations:main Jan 7, 2022
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
* test: add manual test runs

* fixup! debug on push

* fixup! add for individual auth case

* fixup! add support for org auth

* fixup! schedule full runs weekly

* fixup! stricter label filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants