-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add manual test runs #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a couple questions but overall this looks good!
@@ -8,7 +8,7 @@ on: | |||
# │ │ │ ┌───────────── month (1 - 12 or JAN-DEC) | |||
# │ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT) | |||
# * * * * * | |||
- cron: '0 0 * * *' | |||
- cron: '0 0 * * 3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal on this change to save on rate limits? Overall GitHub resources/churn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
uses: actions/checkout@v2 | ||
with: | ||
ref: ${{ github.event.pull_request.head.ref }} | ||
fetch-depth: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what's the reason for fetch-depth: 2
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will revisit here with more context, seems architectural though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This looks great.
* test: add manual test runs * fixup! debug on push * fixup! add for individual auth case * fixup! add support for org auth * fixup! schedule full runs weekly * fixup! stricter label filter
This tunes our acceptance testing in a couple of ways:
See https://github.com/jcudit/terraform-provider-github/actions/workflows/dotcom-acceptance-tests-manual.yml for example test runs and jcudit#1 as an example of labelling.