Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with terraform and go-github Go versions #370

Closed
benj-fletch opened this issue Feb 28, 2020 · 0 comments · Fixed by #372
Closed

Align with terraform and go-github Go versions #370

benj-fletch opened this issue Feb 28, 2020 · 0 comments · Fixed by #372

Comments

@benj-fletch
Copy link
Contributor

benj-fletch commented Feb 28, 2020

I have noticed that we are out of sync with the Go versions of 2 main dependencies that this repository has:

Currently we are using Go v1.11 in our repo. (e.g. in the Travis CI build

I propose that we need to push our version of Go to at least v1.13 otherwise we will encounter issues when trying to pull in new features from those libraries.

This was evidenced in #369 where a previous commit had updated Terraform to v0.12.20 which introduced a Go SDK method present in go 1.12 onwards and failed the Travis build until this was rectified.

Happy to hear opinions on this update and any issues that we might see

jcudit pushed a commit that referenced this issue Mar 5, 2020
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant