Check team ID format at plan (#253)

* Add validateTeamIDFunc function

* Add validation of teamID at plan time

github/resource_github_team_membership.go

@@ -24,9 +24,10 @@ func resourceGithubTeamMembership() *schema.Resource {
 
 		Schema: map[string]*schema.Schema{
 			"team_id": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validateTeamIDFunc,
 			},
 			"username": {
 				Type:             schema.TypeString,

github/resource_github_team_repository.go

@@ -22,9 +22,10 @@ func resourceGithubTeamRepository() *schema.Resource {
 
 		Schema: map[string]*schema.Schema{
 			"team_id": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validateTeamIDFunc,
 			},
 			"repository": {
 				Type:     schema.TypeString,

github/util.go

@@ -2,6 +2,7 @@ package github
 
 import (
 	"fmt"
+	"strconv"
 	"strings"
 
 	"github.com/hashicorp/terraform/helper/schema"
@@ -91,3 +92,16 @@ func (e *unconvertibleIdError) Error() string {
 	return fmt.Sprintf("Unexpected ID format (%q), expected numerical ID. %s",
 		e.OriginalId, e.OriginalError.Error())
 }
+
+func validateTeamIDFunc(v interface{}, keyName string) (we []string, errors []error) {
+	teamIDString, ok := v.(string)
+	if !ok {
+		return nil, []error{fmt.Errorf("expected type of %s to be string", keyName)}
+	}
+	// Check that the team ID can be converted to an int
+	if _, err := strconv.ParseInt(teamIDString, 10, 64); err != nil {
+		return nil, []error{unconvertibleIdErr(teamIDString, err)}
+	}
+
+	return
+}

github/util_test.go

@@ -5,6 +5,37 @@ import (
 	"unicode"
 )
 
+func TestAccValidateTeamIDFunc(t *testing.T) {
+	// warnings, errors := validateTeamIDFunc(interface{"1234567"})
+
+	cases := []struct {
+		TeamID   interface{}
+		ErrCount int
+	}{
+		{
+
+			TeamID:   "1234567",
+			ErrCount: 0,
+		},
+		{
+			// an int cannot be cast to a string
+			TeamID:   1234567,
+			ErrCount: 1,
+		},
+		{
+			TeamID:   "notAnInt",
+			ErrCount: 1,
+		},
+	}
+
+	for _, tc := range cases {
+		_, errors := validateTeamIDFunc(tc.TeamID, "keyName")
+		if len(errors) != tc.ErrCount {
+			t.Fatalf("Expected %d validation error but got %d", tc.ErrCount, len(errors))
+		}
+	}
+}
+
 func TestAccGithubUtilRole_validation(t *testing.T) {
 	cases := []struct {
 		Value    string