Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assorted Sonar issues #70

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix assorted Sonar issues #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c013d1b
Disable vsce package interactive prompt in build.ps1
fourls Oct 11, 2024
9a2dee6
Tidy up Sonar issues
fourls Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion companion/delphilint-vscode/src/command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ async function retrieveEffectiveConfiguration(
config.projectKey = projectOptions.projectKey();
console.log(settings.getSonarTokens());

let sonarTokens = settings.getSonarTokens();
const sonarTokens = settings.getSonarTokens();

config.apiToken =
sonarTokens[projectOptions.sonarHostUrl()]?.[
Expand Down
2 changes: 1 addition & 1 deletion scripts/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ function Invoke-VscCompanionCompile {
Push-Location (Join-Path $PSScriptRoot ..\companion\delphilint-vscode)
try {
& npm install
& npx @vscode/vsce package --skip-license
& npx -y @vscode/vsce package --skip-license
}
finally {
Pop-Location
Expand Down
3 changes: 1 addition & 2 deletions ...r/delphilint-server/src/main/java/au/com/integradev/delphilint/server/AnalysisServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,7 @@ public void analyze(RequestAnalyze requestAnalyze, Consumer<LintMessage> sendMes
sonarHost,
properties);

ResponseAnalyzeResult result =
ResponseAnalyzeResult.fromIssueSet(issues, logOutput.getMessages());
var result = ResponseAnalyzeResult.fromIssueSet(issues, logOutput.getMessages());
result.convertPathsToAbsolute(requestAnalyze.getBaseDir());
sendMessage.accept(LintMessage.analyzeResult(result));
} catch (SonarHostUnauthorizedException e) {
Expand Down
Loading