Replace Bearer authentication with HTTP Basic for SQ 9.9 support #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cirras
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
I was initially a bit hesitant about switching to basic authentication when the documentation for newer SonarQube versions clearly leans towards bearer authentication, but the official SonarLint implementations also use basic authentication in their HTTP client so that's good enough for me.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a token is provided, DelphiLint currently uses the Bearer authentication scheme to authenticate with the SonarQube server. This is apparently not supported by SonarQube 9.9, see 9.9 docs:
This PR alters the server to use HTTP Basic auth instead. This is possible as the latest version still supports the HTTP Basic scheme, see 10.6 docs: