Bug/#22165 Mumie task not editable after deleting server structure #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgoltz
approved these changes
Mar 9, 2021
lib.php
Outdated
| @@ -61,6 +61,7 @@ function mumie_add_instance($mumie, $mform) { | |||
| * @return int $id id of updated grade item | |||
| */ | |||
| function mumie_update_instance($mumie, $mform) { | |||
| debugging(json_encode($mumie)); | |||
There was a problem hiding this comment.
Seems like you forgot this line ;)
mod_form.php
Outdated
| if ($completecourse) { | ||
| $data->mumie_complete_course = 1; | ||
| $server = \auth_mumie\mumie_server::get_by_urlprefix($data->server); | ||
| if ($server->get_urlprefix()) { |
There was a problem hiding this comment.
super tiny thing you don't have to change:
I usually use get_id() to check if an entry exists. It makes sense to have an object with a name and URL that's not in the database (e.g. when validating, before upsert etc) but there is no situation where a server object would have an id while not also having a DB entry.
jtgoltz
deleted the
bug/#22165-mumie-task-not-editable-after-deleting-server-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.