Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Prepare release 1.7.0 - Add token to Blackbox Exporter ConfigMap #170

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

carlkyrillos
Copy link
Contributor

@carlkyrillos carlkyrillos commented Aug 18, 2021

Description

Version bump to 1.7.0 that fixes the Endpoint Detailed dashboard that would incorrectly show the grafana UI endpoint as down. This bugfix adds a ServiceAccount with namespace:get permissions and adds the ServiceAccount's token to the Blackbox Exporter ConfigMap so the Blackbox probe requests can reach the grafana endpoint that is behind a proxy.

JIRA: https://issues.redhat.com/browse/MGDAPI-2282

Verification

  1. Create a new OSD cluster via OpenShift and target it once it has finished provisioning.
  2. Pull this PR from the integreatly-operator repo and change this line to point to the image stored in my Quay repository:
    image: quay.io/ckyrillo/application-monitoring-operator:v1.7.0
  3. Install RHOAM from the command line to the remote cluster using the PR from Step 2.
  4. Once the installation is complete, verify that the "grafana-ui UP/DOWN Status" panel in the Endpoint Dashboard from the redhat-rhoam-middleware-monitoring-operator grafana route correctly displays that the grafana service is UP.

Screenshot of the dashboard without the bugfix:
MGDAPI-2282-bug

Screenshot of the dashboard with the bugfix:
MGDAPI-2282-bugfix

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

…er and add a bearer token to the Blackbox Exporter ConfigMap.
@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pb82 after the PR has been reviewed.
You can assign the PR to them by writing /assign @pb82 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carlkyrillos carlkyrillos changed the title Initial implementation to create a ServiceAccount for Blackbox Export… Add token to Blackbox Exporter ConfigMap Aug 18, 2021
@carlkyrillos
Copy link
Contributor Author

/retest

@carlkyrillos carlkyrillos changed the title Add token to Blackbox Exporter ConfigMap Prepare release 1.7.0 - Add token to Blackbox Exporter ConfigMap Aug 19, 2021
@carlkyrillos carlkyrillos requested a review from matskiv August 19, 2021 20:17
@jackdelahunt
Copy link
Contributor

  • Installed rhoam with custom branch
  • grafana-ui UP/DOWN Status was all green

image

/lgtm

@carlkyrillos
Copy link
Contributor Author

/assign @pb82
Could you take a look at this PR when you get a chance?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants