This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Prepare release 1.7.0 - Add token to Blackbox Exporter ConfigMap #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and add a bearer token to the Blackbox Exporter ConfigMap.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
carlkyrillos
changed the title
Initial implementation to create a ServiceAccount for Blackbox Export…
Add token to Blackbox Exporter ConfigMap
Aug 18, 2021
/retest |
matskiv
reviewed
Aug 19, 2021
deploy/cluster-roles/blackbox-exporter-clusterrole_binding.yaml
Outdated
Show resolved
Hide resolved
matskiv
reviewed
Aug 19, 2021
pkg/controller/applicationmonitoring/applicationmonitoring_controller.go
Outdated
Show resolved
Hide resolved
matskiv
reviewed
Aug 19, 2021
pkg/controller/applicationmonitoring/applicationmonitoring_controller.go
Outdated
Show resolved
Hide resolved
…RB, and prepared 1.7.0 release."
carlkyrillos
changed the title
Add token to Blackbox Exporter ConfigMap
Prepare release 1.7.0 - Add token to Blackbox Exporter ConfigMap
Aug 19, 2021
/assign @pb82 |
Merged
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Version bump to 1.7.0 that fixes the Endpoint Detailed dashboard that would incorrectly show the grafana UI endpoint as down. This bugfix adds a ServiceAccount with namespace:get permissions and adds the ServiceAccount's token to the Blackbox Exporter ConfigMap so the Blackbox probe requests can reach the grafana endpoint that is behind a proxy.
JIRA: https://issues.redhat.com/browse/MGDAPI-2282
Verification
image: quay.io/ckyrillo/application-monitoring-operator:v1.7.0
Screenshot of the dashboard without the bugfix:
Screenshot of the dashboard with the bugfix:
Type of change
Checklist