v1.8.0 #167
v1.8.0 #167
Conversation
| value, exist := os.LookupEnv("LOCAL_INSTALL") | ||
| if exist { | ||
| // If local install is true then do not skip service account creation | ||
| if value == "True" { | ||
| return "False" | ||
| } else { | ||
| return "True" | ||
| } | ||
| } | ||
|
|
||
| return "False" |
There was a problem hiding this comment.
btw: in the version of operatorSDK that is used here currently, there is an env var that can be used to check if it's running locally, see:
https://github.com/integr8ly/application-monitoring-operator/blob/master/vendor/github.com/operator-framework/operator-sdk/pkg/k8sutil/k8sutil.go#L183
There was a problem hiding this comment.
I just realized that if we rely on the env var that I reference in the comment above, it will break whenever newer operator-sdk is used, so ignore this.
There are better ways to check if it's running locally, e.g.:
https://github.com/integr8ly/integreatly-operator/blob/master/pkg/resources/k8s/k8sutil.go#L26-L39
but for now, we can leave it as is.
|
Followed the verification steps, prometheus operator image is correct and all pods are created and working /lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: matskiv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This pr updates AMO to 1.8.0. In this update we have updated the image used by prometheus, and fixed a bug relating to grafana not creating a service account when installed locally.
JIRA
https://issues.redhat.com/browse/MGDAPI-2372
Verification
quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:19ecf8f3cb62545bc81eeddd3ef8adc105ec5bad5538ee556aade7eb8f9d6dbf