Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

label alertmanager service #147

Merged
merged 2 commits into from
Aug 25, 2020
Merged

label alertmanager service #147

merged 2 commits into from
Aug 25, 2020

Conversation

pb82
Copy link
Contributor

@pb82 pb82 commented Aug 25, 2020

Label the alertmanager service to propagate the label down to the alertmanager endpoint. This endpoint is already scraped by an existing prometheus service monitor.

So by only adding this label we get all the alertmanager metrics that are relevant for INTLY-6634.

@david-martin does this approach make sense for you (modifying the RHMI1 AMO) or would you prefer to label the service in ansible?

@pb82 pb82 requested a review from david-martin August 25, 2020 12:01
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@david-martin
Copy link
Member

@pb82 Sure, if you're happy to do a v0 release.

existing prometheus service monitor

Which service monitor is this and what creates it?

@pb82
Copy link
Contributor Author

pb82 commented Aug 25, 2020

@david-martin it's the prometheus service monitor and we create it: https://github.com/integr8ly/application-monitoring-operator/blob/master/templates/prometheus-servicemonitor.yaml

it watches all endpoints in the namespace that have the monitoring label and a web port.

@pb82 pb82 merged commit 9b8ec8c into v0 Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants