Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding path_as_pattern for netcdf #22

Merged
merged 31 commits into from
Jan 25, 2019
Merged

Adding path_as_pattern for netcdf #22

merged 31 commits into from
Jan 25, 2019

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Nov 19, 2018

Still need to add in a version check for xarray or pin the version higher than 0.11.2 to ensure that encoding['source'] exists.

@jsignell
Copy link
Member Author

Note discussion ongoing at pydata/xarray#2550

@jsignell
Copy link
Member Author

jsignell commented Jan 11, 2019

This might get subsumed by #25.

@jsignell jsignell force-pushed the jsignell/netcdf_pattern branch from e7b8033 to ffad7d9 Compare January 23, 2019 16:40
@jsignell
Copy link
Member Author

Closes #30

@jsignell jsignell changed the title [WIP] Adding path_as_pattern for netcdf Adding path_as_pattern for netcdf Jan 23, 2019
@jsignell jsignell requested a review from martindurant January 24, 2019 19:15
@jsignell jsignell self-assigned this Jan 24, 2019
@jsignell jsignell mentioned this pull request Jan 24, 2019
5 tasks
@jsignell jsignell force-pushed the jsignell/netcdf_pattern branch from 0b51fec to 7c45ae9 Compare January 24, 2019 21:39
@martindurant
Copy link
Member

Dask project repos tend to do something like

bash miniconda.sh -b -p $HOME/miniconda
export PATH="$HOME/miniconda/bin:$PATH"
conda config --set always_yes yes --set changeps1 no
conda update conda

conda create -n test python=3.6 pytest
source activate test
conda install -c conda-forge ...

@jsignell
Copy link
Member Author

closes #35

@jsignell
Copy link
Member Author

I'm going to merge this if it passes. I think it is sane and good.

@martindurant
Copy link
Member

Glad to hear it!

@jsignell jsignell merged commit 88c89b5 into master Jan 25, 2019
@jsignell jsignell deleted the jsignell/netcdf_pattern branch January 25, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants