Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include essential options to token cache key #1161

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Include essential options to token cache key #1161

merged 1 commit into from
Oct 26, 2024

Conversation

int128
Copy link
Owner

@int128 int128 commented Oct 26, 2024 •
edited
Loading

Resolve #1132.

int128
int128 commented Oct 26, 2024
View reviewed changes
pkg/tokencache/types.go
SkipTLSVerify bool
Provider oidc.Provider
TLSClientConfig tlsclientconfig.Config
Username string
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #404

@int128 int128 marked this pull request as ready for review October 26, 2024 12:42
@int128 int128 merged commit f1f2a37 into master Oct 26, 2024
22 checks passed
@int128 int128 deleted the int128/Include-essential-options-to-token-cache-key branch October 26, 2024 12:42
@BrewTestBot BrewTestBot mentioned this pull request Nov 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--oidc-use-access-token incorrectly hits cache
1 participant
@int128