Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pull request cache behavior #592

Merged
merged 3 commits into from
Nov 23, 2023
Merged

feat: add pull request cache behavior #592

merged 3 commits into from
Nov 23, 2023

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Oct 5, 2023

When pull_request_cache input is set, this action instructs docker/build-push-action to import and export cache of the pull request.

cache-from: |
  type=registry,ref=IMAGE:pr-1
  type=registry,ref=IMAGE:main
cache-to: type=registry,ref=IMAGE:pr-1,mode=max

This is useful when you want to improve build cache between consecutive commits for a same pull request.

@neilime
Copy link
Contributor Author

neilime commented Oct 24, 2023

@int128 can you have a check on this please?

@artificial-aidan
Copy link

Just tested this and it is working great for us.

Copy link
Owner

@int128 int128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great contribution!
I'd like to add a commit of some suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
action.yaml Show resolved Hide resolved
@int128 int128 merged commit c434e6e into int128:main Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants