Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only logs missing schema warning once #171

Merged
merged 4 commits into from
Aug 13, 2019

Conversation

brendanjryan
Copy link
Contributor

Changes the output produced by the --ignore-missing-schemas to only print Warning: Set to ignore missing schemas once per invocation instead of once per file provided.

Before:

bin/kubeval --ignore-missing-schemas fixtures/valid.yaml fixtures/valid.yaml
Warning: Set to ignore missing schemas
The file fixtures/valid.yaml contains a valid ReplicationController
Warning: Set to ignore missing schemas
The file fixtures/valid.yaml contains a valid ReplicationController

After:

bin/kubeval --ignore-missing-schemas fixtures/valid.yaml fixtures/valid.yaml 
Warning: Set to ignore missing schemas
The file fixtures/valid.yaml contains a valid ReplicationController
The file fixtures/valid.yaml contains a valid ReplicationController

@brendanjryan
Copy link
Contributor Author

cc @garethr

@garethr
Copy link
Collaborator

garethr commented Aug 13, 2019

Looks like this needs a rebase with master to merge, but thanks for the fix. I'll probably wait for this and docs for #169 and ship a new release with those in.

@brendanjryan brendanjryan changed the title donly logs missing schema warning once Only logs missing schema warning once Aug 13, 2019
# Conflicts:
#	kubeval/kubeval.go
@brendanjryan
Copy link
Contributor Author

Thank YOU. It should be good to go now

@garethr garethr merged commit ecd0802 into instrumenta:master Aug 13, 2019
@brendanjryan brendanjryan deleted the bjr-single-warning branch August 14, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants