prevent youtube videos from auto-looping #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the fix was to change a `pause()` to a `stop()` as shared in mediaelement#1851 in addition, we had to turn off timeupdates in the UNSTARTED youtube event handler, because when the youtube video finished, it would trigger ENDED, then PLAYING for some reason, then UNSTARTED. so after PLAYING turns timeupdates on, we turn them back on in UNSTARTED.
|
new commit up, don't know how to reject the old approval, but needs another look plz @astephenb |
|
My review still stands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fix was to change a
pause()to astop()as shared inmediaelement#1851
in addition, we had to turn off timeupdates in the UNSTARTED youtube
event handler, because when the youtube video finished, it would trigger
ENDED, then PLAYING for some reason, then UNSTARTED. so after PLAYING
turns timeupdates on, we turn them back on in UNSTARTED.