INSTUI-2878 Upgrade storybook to 6.1.18 #399
Conversation
|
|
||
| module.exports = { | ||
| stories: ['../stories.js'] | ||
| } |
There was a problem hiding this comment.
This is the new syntax, see https://storybook.js.org/blog/declarative-storybook-configuration/
| @@ -48,54 +35,9 @@ addParameters({ | |||
| name: 'instructure-ui', | |||
| brandUrl: 'https://instructure.design', | |||
| brandImage: | |||
| 'https://instructure.design/icons-bea652a7d0546b99c7cba9d3b4a538ee/favicon-32x32.png' | |||
| 'https://instructure.design/icons-bea652a7d0546b99c7cba9d3b4a538ee/favicon-32x32.png' // TODO this URL is broken | |||
| }), | |||
| showPanel: false, | |||
| isFullscreen: false | |||
| } | |||
| }) | |||
There was a problem hiding this comment.
again, the new format, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#using-previewjs
| * SOFTWARE. | ||
| */ | ||
|
|
||
| import { storiesOf } from '@storybook/react' |
There was a problem hiding this comment.
Although storiesOf API is legacy https://github.com/storybookjs/storybook/blob/next/lib/core/docs/storiesOf.md they do not seem to offer a new API to programatically load lots of stories, see storybookjs/storybook#9828
| '../../', | ||
| true, | ||
| /^.*\/src\/.*\.examples\.js$/, | ||
| 'lazy' |
There was a problem hiding this comment.
This was one of the things causing issues with Storybook 6. We were loading our modules lazily with a promise (this is some barely documented Webpack feature) that caused Storybook to throw errors saying "Error: Cannot add a story when not configuring ...". I've set this to 'sync', see stories.js
matyasf
force-pushed
the
storybook_upgrade
branch
from
6a6fef2 to
6a73a9b
Compare
matyasf
changed the title
|
Somehow not all of our examples are shown with this new upgrade. |
| if (!config.renderPage) { | ||
| console.warn('A default is no longer provided for \`renderPage\`, you should supply it to the config instead') | ||
| } | ||
|
|
||
| if (!config.renderExample) { | ||
| console.warn('A default is no longer provided for \`renderExample\`, you should supply it to the config instead') | ||
| } |
There was a problem hiding this comment.
here they likely wanted to check the opposite (if (config.renderExample)), see 3abd6ca#diff-f82b6242f20fe2b1c9d6cf5c3522ad1c9463b3a9d8bd703c307050df0f079007
hmm I fixed this in one place, then there must be other places where the |
…r in Billboard example
…not needed warning
…rybook story generation works
matyasf
force-pushed
the
storybook_upgrade
branch
from
7e88040 to
8e13788
Compare
I solved the conflict and fixed all the errors that components were throwing |
Uprade storybook to the latest version, hopefully this will help with the Chromatic issues. Also removed some exotic code.