Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the local dev login page with the Oauth login page #313

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

nerdalert
Copy link
Member

@nerdalert nerdalert commented Nov 1, 2024

Changes the local login page from the default Patternfly form to match the SaaS login when started in dev mode. I don't really like the text but we can set it to whatever in another PR:

image

This also breaks out locallogin in a similar pattern to github login to resolve hydration errors from nextjs v15.

- Break out the local login into a new client side file to avoid
rehydration errors in nextjs v15
Signed-off-by: Brent Salisbury <[email protected]>
@nerdalert nerdalert marked this pull request as ready for review November 13, 2024 02:35
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 09b0968 into instructlab:main Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants