helm/web-deployment: add env vars for log level of autotrace_webhook #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These environment variables come useful during debugging when the autotrace webhook is used. Signed-off-by: Antonio Gutierrez <[email protected]>
nfisher
approved these changes
Nov 29, 2021
| # autotrace-webhook binaries to log in debug level | ||
| debug_autotrace: false | ||
| # For the mini ones minikube, minishift set to true | ||
| nodeport: false |
There was a problem hiding this comment.
Suggested change
| nodeport: false | |
| nodeport: 0 |
Rather than a boolean I would make it a "optional" int value so the port can be adjusted to whatever the user wants. With a 0 value the nodePort would be disabled. Also Helm discourages heavy nesting. I'd probably opt for webDebugAutotrace and webNodePort. If we wanted dynamic assignment by the cluster of a nodePort then it might make sense to have a boolean and a numeric but it's probably over-engineering for a demo app.
| @@ -11,7 +11,7 @@ spec: | |||
| targetPort: 8080 | |||
| selector: | |||
| service: web | |||
| {{ if .Values.nodeport }} | |||
| {{ if .Values.web.nodeport }} | |||
There was a problem hiding this comment.
No change required if this is numeric.
| @@ -11,7 +11,7 @@ spec: | |||
| targetPort: 8080 | |||
There was a problem hiding this comment.
Suggested change
| targetPort: 8080 | |
| {{ if .Values.web.nodeport }} | |
| nodePort: {{ .Values.web.nodeport }} | |
| {{ else }} | |
| targetPort: 8080 | |
| {{ end }} |
|
|
||
| web: | ||
| # autotrace-webhook binaries to log in debug level | ||
| debug_autotrace: false |
There was a problem hiding this comment.
Suggested change
| debug_autotrace: false | |
| debugAutotrace: false |
Ideally we'd maintain consistency with the rest of the config and not use snake case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These environment variables come useful during debugging when the autotrace
webhook is used.
Signed-off-by: Antonio Gutierrez [email protected]