Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(currency): google-cloud library versions has been updated #578

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

CagriYonca
Copy link
Contributor

@CagriYonca CagriYonca commented Aug 8, 2024

Versions of modules below has been updated for the Python runtime versions 3.8, 3.9, 3.10, 3.11, 3.12:

  • google-cloud-pubsub version has been changed up to 2.23.0 (JIRA/INSTA-5312)
  • google-cloud-storage version has been changed up to 2.14.0 (JIRA/INSTA-5313)

Since grpcio is not supported by beta versions of Python 3.13, we don't support Python 3.13.

@CagriYonca CagriYonca self-assigned this Aug 8, 2024
@pvital
Copy link
Member

pvital commented Aug 9, 2024

* google-cloud-pubsub version has been changed up to 2.14.0 
* google-cloud-storage version has been changed up to 2.23.0 

I guess you changed the order of the versions:

  • google-cloud-pubsub's most recent version is 2.23.0.
  • google-cloud-storage, you are setting an upper-bound as 2.1.40. I can see the most recent version is 2.18.2. Are the versions between 2.14.0 and 2.18.2 not working?

tests/requirements-310.txt Outdated Show resolved Hide resolved
tests/requirements-313.txt Outdated Show resolved Hide resolved
@CagriYonca
Copy link
Contributor Author

* google-cloud-pubsub version has been changed up to 2.14.0 
* google-cloud-storage version has been changed up to 2.23.0 

I guess you changed the order of the versions:

  • google-cloud-pubsub's most recent version is 2.23.0.
  • google-cloud-storage, you are setting an upper-bound as 2.1.40. I can see the most recent version is 2.18.2. Are the versions between 2.14.0 and 2.18.2 not working?

Yes, I have mistyped version numbers, we're supporting pubsub up to 2.23.0 and storage up to 2.14.0. It's failing for google-cloud-storage versions after 2.14.0:
image

@CagriYonca CagriYonca requested a review from pvital August 9, 2024 11:08
tests/requirements-310.txt Outdated Show resolved Hide resolved
@CagriYonca CagriYonca requested a review from pvital August 12, 2024 09:09
@CagriYonca CagriYonca added this to the H2-2024 milestone Aug 12, 2024
tests/requirements-313.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit ef3c3c5 into master Aug 19, 2024
13 checks passed
@CagriYonca CagriYonca deleted the module_version_update branch August 19, 2024 06:21
@CagriYonca CagriYonca restored the module_version_update branch August 19, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants