Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Upgrade quarkus from 1.2.1.Final to 1.9.0.Final #46

Merged
merged 8 commits into from
Dec 10, 2020
Merged

[Breaking change] Upgrade quarkus from 1.2.1.Final to 1.9.0.Final #46

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d07f72b
Upgrade quarkus from 1.2.1.Final to the latest 1.9.0.Final in order t…
dlbock Dec 4, 2020
693533e
Add additional error messaging if we fail to update the CustomResourc…
dlbock Dec 7, 2020
e406181
Update the local testing with Kind with some scripts to create and de…
dlbock Dec 4, 2020
9de49c2
Update the operator-artifacts.jsonnet template to include the version…
dlbock Dec 7, 2020
d5cd161
Do not push the latest tag for the operator Docker image anymore as w…
dlbock Dec 10, 2020
610c77b
Update Instana docs link from docs.instana.io to www.instana.com/docs
dlbock Dec 10, 2020
581a616
No need to add the version for the instana/instana-agent-operator ima…
dlbock Dec 10, 2020
f5ac061
Change the format of the error message that is logged when we fail t…
dlbock Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ pipeline {
if (isFullRelease(TAG)) {
docker.withRegistry('https://index.docker.io/v1/', '8a04e3ab-c6db-44af-8198-1beb391c98d2') {
def image = docker.build("instana/instana-agent-operator:$VERSION", BUILD_ARGS)

image.push()
image.push('latest')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiggzz After discussion with Henning/Miel/Et al., we decided to no longer push the latest tag and to make the dependency between the operator image and the operator yaml more explicit, i.e. if a customer wants a more recent version of the operator, they have to update their operator yaml.

}
} else {
echo "Skipping pushing tag because this is a pre-release or branch."
Expand All @@ -46,7 +44,6 @@ pipeline {
// annoyingly no way to reuse the existing image with docker jenkins plugin.
// probably should just pull all of this into a shell script
def image = docker.build("scan.connect.redhat.com/ospid-6da7e6aa-00e1-4355-9c15-21d63fb091b6/instana-agent-operator:$VERSION", BUILD_ARGS)

image.push()
}
}
Expand Down