Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.14 #84

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Add Go 1.14 #84

merged 2 commits into from
Feb 27, 2020

Conversation

andrewslotin
Copy link
Contributor

@andrewslotin andrewslotin commented Feb 27, 2020

This PR adds Go v1.14 to the CI build matrix and drops official support for v1.7

github.com/looplab/fsm@master has recently dropped support of 1.7 by introducing the use of sort.Slice that was only added in 1.8. As a result any app that uses go1.7 and does not have its dependencies vendored will raise a compile-time error. A suggested workaround would be to vendor github.com/looplab/fsm and lock it to v0.1.0

Andrey Slotin added 2 commits February 27, 2020 11:57
`github.com/looplab/fsm@master` has recently dropped support of 1.7 by
introducing the use of `sort.Slice` that was only added in 1.8. As a
result any app that uses go1.7 and does not have its dependencies
vendored will raise a compile-time error. A suggested temporary
workaround would be to vendor `github.com/looplab/fsm` and lock it to
v0.1.0
Copy link
Contributor

@pglombardo pglombardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewslotin andrewslotin merged commit 6f9536d into master Feb 27, 2020
@andrewslotin andrewslotin deleted the add_go1.14 branch February 27, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants