refactor: update configs folder #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiemKhlifi
requested review from
arnupretorius,
DriesSmit,
RuanJohn,
jcformanek,
siddarthsingh1,
sash-a,
OmaymaMahjoub and
ulricharmel
as code owners
WiemKhlifi
commented
Oct 9, 2024
2 tasks
sash-a
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks Wiem!
Couple small things:
- Just put the default configs in
configs/default(no anakin) anakin/sebulba will share the same configs except for arch to start. If we find that params differ a lot then we can change it later. Because of this I think you can leave the integration tests as is - I think remove the
default_...part of the config file name because they're now in the default folder.
|
Thank you Sasha for these suggestions! Without the |
OmaymaMahjoub
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks @WiemKhlifi for the changes, I added minor request 🙏
sash-a
previously approved these changes
Oct 10, 2024
OmaymaMahjoub
approved these changes
Oct 10, 2024
sash-a
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updating the configs folder.
How?