Add more flexibility to authorization unique identifier expectations #730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code just assumes the unique identifier responds to client ID and issuer. That is currently the case however it is potentially a flawed assumption with new authentication methods being added going forward.
Description
I am currently working to add support to the googleauth library for Workload Identity Federation. As part of this, I am adding a new type of authentication to the googleauth library itself. It is currently assumed that the authorization responds to client_id and issuer, and if either of these are not present then train exits with a stacktrace. This small changes makes train more flexible regarding the authorization object.
Related Issue
googleapis/google-auth-library-ruby#354
Types of changes
Checklist: