Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify step for sudo #557

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Fix verify step for sudo #557

merged 3 commits into from
Jan 23, 2020

Conversation

zenspider
Copy link
Contributor

@zenspider zenspider commented Jan 17, 2020 •
edited
Loading

Fixes regression #548. But we need to test across more platforms. Pushing PR to be accessible.

@zenspider zenspider requested a review from a team as a code owner January 17, 2020 01:30
@ghost ghost requested review from clintoncwolfe and miah January 17, 2020 01:30
@chef-expeditor
Copy link
Contributor

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@zenspider
Fix refactoring of with_sudo_pty to ssh_connection.
c4bea2e 
This IS the backend, so remove the backend calls.

Signed-off-by: Ryan Davis <[email protected]>
@zenspider
Fix verify step for sudo to be more robust to outside config changes.
fc77ecb 
test-kitchen was setting sudo_command to "sudo -E" which conflicts
with us trying to run `sudo -v`. This bypasses `run` entirely and just
runs `sudo -v` as-is. It would be nice if we could use `sudo_command`,
but we'd have to sanitize it if that were the case.

Signed-off-by: Ryan Davis <[email protected]>
@zenspider
Fix deprecation in test.
4aef4e1 
Signed-off-by: Ryan Davis <[email protected]>
@zenspider zenspider changed the title Refactor with_sudo_pty to BaseConnection (no-op) and SshConnection. Fix verify step for sudo Jan 17, 2020
@codeclimate
Copy link

codeclimate bot commented Jan 17, 2020

Code Climate has analyzed commit 4aef4e1 and detected 0 issues on this pull request.

View more on Code Climate.

clintoncwolfe
clintoncwolfe approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zenspider zenspider merged commit a3b481a into master Jan 23, 2020
@chef-expeditor chef-expeditor bot deleted the zenspider/ssh/fix branch January 23, 2020 00:22
@teknofire teknofire mentioned this pull request Feb 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@miah miah miah approved these changes

Assignees

@zenspider zenspider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenspider @miah @clintoncwolfe