Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute require for require_relative #549

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Substitute require for require_relative #549

merged 1 commit into from
Dec 24, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Dec 20, 2019

require_relative is significantly faster and should be used when available. See @lamont-granquist for the full story.

Signed-off-by: Tim Smith [email protected]

require_relative is significantly faster and should be used when available.

Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 requested a review from a team as a code owner December 20, 2019 23:29
@chef-expeditor
Copy link
Contributor

Hello tas50! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@ghost ghost requested review from clintoncwolfe and miah December 20, 2019 23:29
@codeclimate
Copy link

codeclimate bot commented Dec 20, 2019

Code Climate has analyzed commit 045c3c8 and detected 55 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 55

View more on Code Climate.

Copy link
Contributor

@zenspider zenspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claims of speed should include or cite real benchmarks... Otherwise, this seems fine.

@lamont-granquist
Copy link
Contributor

in chef/chef I did that here:

chef/chef#8508 (comment)

@tas50 tas50 merged commit 8972210 into master Dec 24, 2019
@chef-expeditor chef-expeditor bot deleted the relative branch December 24, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants