Chef 11169 optimize k8s container connection v2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathish Babu <[email protected]>
…hell Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
This allows to use only single session Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
- set reader, writer and PID - define reconnect logic - load session at class level Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Train::Extras::CommandResult.new("", "", 1) | ||
| end | ||
|
|
||
| private | ||
| def strip_ansi_sequences(text) | ||
| text.gsub(/\e\[.*?m/, "").gsub(/\e\]0;.*?\a/, "").gsub(/\e\[A/, "").gsub(/\e\[C/, "").gsub(/\e\[K/, "") |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| Train::Extras::CommandResult.new("", "", 1) | ||
| end | ||
|
|
||
| private | ||
| def strip_ansi_sequences(text) | ||
| text.gsub(/\e\[.*?m/, "").gsub(/\e\]0;.*?\a/, "").gsub(/\e\[A/, "").gsub(/\e\[C/, "").gsub(/\e\[K/, "") |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| Train::Extras::CommandResult.new(res.stdout, res.stderr, res.exitstatus) | ||
| rescue Errno::ENOENT => _e | ||
| def connect | ||
| @reader, @writer, @pid = PTY.spawn("kubectl exec --stdin --tty #{@pod} -n #{@namespace} -c #{@container_name} -- /bin/bash") |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimise the Persistent connection to K8s container
Description
Related Issue
Types of changes
Checklist: