Add missing SDKs for an up-coming work #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Demirok <[email protected]>
|
CC: @skpaterson, @rmoles, @davymcaleer. |
rmoles
requested review from
a team,
Schwad,
james-stocks and
tas50
and removed request for
a team
james-stocks
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
This looks good to me - one thing to check when adding dependencies is that we aren't introducing difficult dependencies to the Chef ecosystem (in particular, gems with native extensions).
I bundle install'ed both this branch and master, and the difference in Gemfile.lock is just aws- gems, which seems good to me.
tas50
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Omer Demirok [email protected]
Add missing SDKs for an up-coming work
Description
These SDKs are needed for the new resources being developed.
Related Issue
Types of changes
Checklist: