Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil checks in google_project_logging_audit_config resource #68

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Oct 23, 2018

Similar to #67

screen shot 2018-10-23 at 11 35 26 am

$ bundle exec inspec exec ~/git/summit-demo -t gcp:// --attrs ~/git/summit-demo/attrs.yaml
bundler: failed to load command: inspec (/usr/local/lib/ruby/gems/2.4.0/bin/inspec)
NoMethodError: undefined method `each' for nil:NilClass
  libraries/google_project_logging_audit_config.rb:25:in `block in initialize'
  libraries/gcp_backend.rb:28:in `catch_gcp_errors'
  libraries/google_project_logging_audit_config.rb:20:in `initialize'
  /Users/apop/git/inspec/lib/inspec/plugin/v1/plugin_types/resource.rb:68:in `initialize'
  /Users/apop/git/inspec/lib/inspec/resource.rb:51:in `new'
  /Users/apop/git/inspec/lib/inspec/resource.rb:51:in `block (3 levels) in create_dsl'

@alexpop alexpop force-pushed the ap/google_project_logging_audit_config-fixes branch from d69253b to a4c76fd Compare October 23, 2018 13:38
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexpop 👍

@skpaterson skpaterson merged commit 253d1fb into master Oct 25, 2018
@skpaterson skpaterson deleted the ap/google_project_logging_audit_config-fixes branch October 25, 2018 10:52
skpaterson pushed a commit that referenced this pull request Jan 21, 2019
Add instance group manager resource to InSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants