Add storage bucket IAM resources #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 13, 2018 12:22
…s, members and ACLs. Signed-off-by: Stuart Paterson <[email protected]>
…r consistency. Signed-off-by: Stuart Paterson <[email protected]>
Signed-off-by: Stuart Paterson <[email protected]>
Signed-off-by: Stuart Paterson <[email protected]>
…ces, update README and tf file. Signed-off-by: Stuart Paterson <[email protected]>
ghost
reviewed
Aug 16, 2018
| @@ -41,7 +41,13 @@ module GCPInspecConfig | |||
| :gcp_ext_vm_data_disk_name => "gcp-inspec-generic-ext-linux-vm-data-disk", | |||
| :gcp_ext_vm_data_disk_size => "f1-micro", | |||
| :gcp_ext_vm_data_disk_image => "ubuntu-os-cloud/ubuntu-1604-lts", | |||
| :gcp_storage_bucket_name => "gcp-inspec-storage-bucket-#{(0...15).map { (65 + rand(26)).chr }.join.downcase}", | |||
| :gcp_storage_bucket_name => "gcp-inspec-storage-bucket-#{(0...25).map { (65 + rand(26)).chr }.join.downcase}", | |||
There was a problem hiding this comment.
Minor but this could surely be pulled out into an any_string function
There was a problem hiding this comment.
agreed, can revisit next time round
ghost
reviewed
Aug 16, 2018
|
|
||
| control 'gcp-storage-object-acl-1.0' do | ||
|
|
||
| only_if { gcp_enable_privileged_resources.to_i == 1 } |
There was a problem hiding this comment.
we're comparing integers - the config comes through as a string
There was a problem hiding this comment.
Ah - at a glance looked like boolean to integer
There was a problem hiding this comment.
it's funny as I'd have preferred to use booleans but tf converts true/false values to "0" and "1" - https://www.terraform.io/docs/configuration/variables.html
ghost
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Storage Bucket IAM resources. More details below: