Add kms resources #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 27, 2018 15:48
Signed-off-by: Stuart Paterson <[email protected]>
…dings resources, tests and docs. Correction to project IAM binding documented properties list. Documentation updates for project IAM binding. Update string representation for google_project_iam_binding. Signed-off-by: Stuart Paterson <[email protected]>
Updated terraform script to create sample crypto keys and policy bindings. Added associated documentation and tests. Signed-off-by: Stuart Paterson <[email protected]>
Signed-off-by: Stuart Paterson <[email protected]>
…m_bindings resources. Also updated README with new resources. Minor changes to google_kms_crypto_key(s) and google_kms_key_ring_iam_binding(s) resources/documentation. Signed-off-by: Stuart Paterson <[email protected]>
Signed-off-by: Stuart Paterson <[email protected]>
skpaterson
requested review from
jquick,
russellseymour,
chris-rock and
davymcaleer
added 2 commits
July 2, 2018 10:09
Signed-off-by: Stuart Paterson <[email protected]>
…urces. Signed-off-by: Stuart Paterson <[email protected]>
davymcaleer
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.