Fix Service account keys, MM-updates #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add encryption, retention policy to buckets * snake case * Typo * Typo * Add test, fix docs on sa key * Remove test Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
* SD for Cloud DNS * use getRelativePath Signed-off-by: Modular Magician <[email protected]>
* more product renames * fix empty display names * more moves Signed-off-by: Modular Magician <[email protected]>
* adds scaling properties to appengine standard version * use optional scaling properties as it defaults to automaticScaling * cover all automatic_scaling properties during test * update test for standard appengine version Signed-off-by: Modular Magician <[email protected]>
* Add enum values generation to documentation, remove previous handwritten lists unless they add value * Add possible enum values to inspec doc generation * Add default, possible values to the schema description * Format fixes * Try spacing to see how md looks * PR feedback * Order of operations * Bigger spacefor markdown Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
* Add user labels kv map to sql instance * Add userLabels to sql instance Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Sam Levenick <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
* Add back requireds on stripquery * Move required to terraform.yaml, add description on empty blocks' * Fixed to preserve backwards compatibility * Remove last default in description * Default back to false in ansible urlmaps Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Sam Levenick <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
…1) (#395) * account for iam vs primative bigquery roles * add test, fix description * s/EDITOR/WRITER * fix test * comments Signed-off-by: Modular Magician <[email protected]>
skpaterson
added
the
Version: Bump Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix service account keys plural resource
Various MM updates, tests
Issues Resolved
Fixes: #249