Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspec-gcp 1.0 #226

Merged
merged 98 commits into from
Apr 6, 2020
Merged

inspec-gcp 1.0 #226

merged 98 commits into from
Apr 6, 2020

Conversation

slevenick
Copy link
Collaborator

@slevenick slevenick commented Jan 15, 2020 •
edited
Loading

Description

Big features included are migrating the rest of the resources to MM, beta flag for pulling the beta version of the resource.

Code is complete now, all resources except for google_user and google_users converted. Need to manually migrate some docs examples

@slevenick slevenick requested a review from a team as a code owner January 15, 2020 23:47
@slevenick slevenick mentioned this pull request Feb 4, 2020
Open
slevenick and others added 28 commits February 19, 2020 16:27
@slevenick
Update partially to terraform 0.12 syntax
ce846b2 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Pin rubocop as cop names changed
16ae006 
Signed-off-by: Sam Levenick <[email protected]>
@chrisst @slevenick
Moving nexthop ILB to GA
5000485 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Refactor InSpec terraform file
dc2ad25 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Update inspec container for new rubocop and terraform versions
c4dab61 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Updating to 3.0, move handwritten firewalls test to new namespace
74e3c97
@slevenick
Updating inspec integration tests to terraform 3.0
f58aa3d 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Update filename cop to check for 100 character files which break the …
2f06b76 
…zip distribution

Signed-off-by: Sam Levenick <[email protected]>
@slevenick
These fields were duplicated, they shouldn't be
4bd5a64 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Remove kind from tests for generated resources, it is not useful
a30ee70 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Remove kind tests
ebc651d 
Signed-off-by: Sam Levenick <[email protected]>
@modular-magician @emilymye @slevenick
Try to clarify scheduler docs on pubsub (#290)
8bfffb7 
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: emily <[email protected]>
@slevenick
Fingerprint is not a tag, remove assertion
d20c32b 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Inspec 1
2ad5fd6 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
remove regional cluster/node pool resources, fix handwritten tests
06d15ab 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Update tests for generated resources, fingerprint is NOT considered a…
54e4bfc 
… label

Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Inspec cluster updates
aaa2ba6 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Rename handwritten test to preserve after generation
3b8e80a 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Inspec storage
0488dae 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Update kms, spanner IAM tests for generation
8d4bfbd 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Move KMS tests to handwritten, use google_projects.project_ids instea…
9581c83 
…d of project_names in loop test

Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Inspec kms generated
aa9fff6 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Make db instance name static for VCR testing
964972b 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
InSpec generate SQL db instance, user
67d9951 
Signed-off-by: Modular Magician <[email protected]>
@slevenick
Re-add random string to db name (needed because gcp cant reuse names)
15da960 
Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Add generation for project_sink, project_exclusion for InSpec
135f7ce 
Signed-off-by: Modular Magician <[email protected]>
@modular-magician @slevenick
Allow target to accept other resource types (#302)
f03c8b2 
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Ty Larrabee <[email protected]>
@slevenick
Inspec iam gen
4f4a012 
Signed-off-by: Modular Magician <[email protected]>
modular-magician and others added 6 commits March 20, 2020 15:03
@modular-magician
Support for IAM conditions in InSpec, currently only for project (#32…
464a049 
…77) (#365)

Signed-off-by: Modular Magician <[email protected]>
@slevenick
Rubocop
7a67d35
@modular-magician
Update test_terraform.sh (#3283) (#366)
23e7f61 
Signed-off-by: Modular Magician <[email protected]>
@modular-magician
Fix lint issues, adding folder IAM (#3282) (#367)
3df100e 
* Fix lint issues, adding folder IAM

* Newline at end of file

Signed-off-by: Modular Magician <[email protected]>
@modular-magician
GA ILB multi-nic (#3289) (#368)
b51780f 
* GA ILB multi-nic

* Failover is not GA, needs if/else

Signed-off-by: Modular Magician <[email protected]>
@modular-magician
Add serviceusage's consumerquotaoverride. (#3267) (#369)
fe060cc 
Signed-off-by: Modular Magician <[email protected]>
skpaterson
skpaterson suggested changes Mar 25, 2020
View reviewed changes
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @slevenick - couple of minor comments to look at.

test/integration/build/gcp-mm.tf Outdated Show resolved Hide resolved
test/integration/verify/controls/google_organizations.rb Outdated Show resolved Hide resolved
test/integration/verify/controls/google_compute_project_info.rb Outdated Show resolved Hide resolved
@modular-magician
PR feedback (#3307) (#370)
8d04589 
Signed-off-by: Modular Magician <[email protected]>
@lhasadreams
Copy link
Contributor

Great work guys.
@slevenick do you have an estimate for your big release of all issues that were being blocked by this please?

modular-magician and others added 6 commits March 30, 2020 09:32
@modular-magician
ACM: service perimeter's vpc_accessible_services (#3318) (#371)
6e550e4 
Signed-off-by: Modular Magician <[email protected]>
@modular-magician
Add deadLetterPolicy to Pub/Sub Subscription resource (#3305) (#372)
38a3abd 
* Add deadLetterPolicy to Pub/Sub subscription resource

* fix: disable allow_empty_objects, fix docstring, add example

* fix: set max_delivery_attempts

* fix: block and topic name

Signed-off-by: Modular Magician <[email protected]>
@modular-magician
allow google_dns_managed_zone.dnssec_config to be updated (#3313) (#373)
4a15ccf 
* allow update for dns_managed_zone

* add some input trues back in

* add some input trues back in

Signed-off-by: Modular Magician <[email protected]>
@slevenick
Add back iam_bindings resources for backwards compatibility, add note…
acecbbb 
… to markdown about deprecation

Signed-off-by: Sam Levenick <[email protected]>
@slevenick
Randomize org role
db16cac 
Signed-off-by: Sam Levenick <[email protected]>
@modular-magician
Add org id to attributes as it is required in privileged resources (#…
5b293ed 
…3325) (#374)

Signed-off-by: Modular Magician <[email protected]>
@skpaterson
Copy link

Hey @slevenick - two minor issues came up during testing. In both cases the updated resources store a list of strings where previously these were integers e.g.

inspec-gcp/test/integration/verify/controls/google_compute_vms.rb

Line 21 in dc24923

its('instance_ids') { should include gcp_instance_id }

https://github.com/inspec/inspec-gcp/blob/5b293edb68e0295689325c4e3660d040474c8dc3/test/integration/verify/controls/google_compute_firewalls_handwritten.rb

@skpaterson
Copy link

Don't mind if these are either updated or removed if you prefer. Otherwise looks good to go!

@slevenick slevenick requested a review from skpaterson April 2, 2020 17:28
@slevenick
Copy link
Collaborator Author

Don't mind if these are either updated or removed if you prefer. Otherwise looks good to go!

Great! I removed the to_i on those, they should correctly compare now.

@skpaterson skpaterson added the Version: Bump Major Used by github.minor_bump_labels to bump the Major version number. label Apr 6, 2020
@skpaterson
Copy link

Hey @slevenick, had to make a minor update to ensure the major version bump worked as expected. Almost there!

@skpaterson skpaterson merged commit f89a6f1 into inspec:master Apr 6, 2020
@binamov
Copy link
Collaborator

binamov commented Apr 6, 2020

This is great! Thank you all for getting this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skpaterson skpaterson skpaterson approved these changes

Assignees
No one assigned
Labels
Version: Bump Major Used by github.minor_bump_labels to bump the Major version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@slevenick @lhasadreams @skpaterson @binamov @chrisst @modular-magician