Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #158

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Update README.md #158

merged 2 commits into from
Jul 17, 2019

Conversation

mjingle
Copy link

@mjingle mjingle commented Jul 17, 2019

Signed-off-by: Mary Jinglewski [email protected]

Description

Updating the versioning reference to reflect best practices.

Signed-off-by: Mary Jinglewski <[email protected]>
@mjingle mjingle requested a review from a team as a code owner July 17, 2019 14:43
Signed-off-by: Mary Jinglewski <[email protected]>
depends:
- name: inspec-gcp
url: https://github.com/inspec/inspec-gcp/archive/master.tar.gz
url: https://github.com/inspec/inspec-gcp/archive/x.tar.gz

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should figure out what our format is going to be and template this a bit better (eg inspec-X.Y.tar.gz or compat instead of inspec... arbitrary).... but just NOT saying "master" right now is more important than getting the format right. I'd even go so far as to ask that this get published immediately.

@zenspider zenspider merged commit e652abc into master Jul 17, 2019
slevenick added a commit to slevenick/inspec-gcp that referenced this pull request Aug 22, 2019
Add support for INTERNAL_SELF_MANAGED backend service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants