Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster method has_logging_enabled? reporting wrong #136

Closed
janderton opened this issue Apr 3, 2019 · 0 comments · Fixed by #137
Closed

google_container_cluster method has_logging_enabled? reporting wrong #136

janderton opened this issue Apr 3, 2019 · 0 comments · Fixed by #137

Comments

@janderton
Copy link

janderton commented Apr 3, 2019

The google_container_cluster method has_logging_enabled? reports false because its not matching "logging.googleapis.com" where the resource is sending "logging.googleapis.com/kubernetes" instead.

Here's the output of my testing:

     ✔  logging_service should not equal nil
     ×  logging_service should equal "logging.googleapis.com"

     expected #<String:83861140> => "logging.googleapis.com"
          got #<String:66556320> => "logging.googleapis.com/kubernetes"

     Compared using equal?, which compares object identity,
     but expected and actual are not the same object. Use
     `expect(actual).to eq(expected)` if you don't care about
     object identity in this example.


     ×  has_logging_enabled? should not equal false

     expected not #<FalseClass:0> => false
              got #<FalseClass:0> => false

     Compared using equal?, which compares object identity.

image

slevenick added a commit to slevenick/inspec-gcp that referenced this issue Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant