-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "conn" leaking #351
Fix "conn" leaking #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for fixing it.
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 72.13% 71.96% -0.17%
==========================================
Files 79 79
Lines 3994 3970 -24
==========================================
- Hits 2881 2857 -24
Misses 954 954
Partials 159 159
Continue to review full report at Codecov.
|
Go tip linter check is failing but it is unrelated to this PR |
The error looks to be a golangci-lint issue: golangci/golangci-lint#896 I would go ahead and merge this PR but I can only do so if travis run was successful. |
…chines with many NICs Signed-off-by: Leandro Martelli <[email protected]>
I've refactored it to log any error messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
On machines with many NICs, it can cause the golang runtime to run out of threads.