Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6: give proper names to some common OptionCodes #348

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

hugelgupf
Copy link
Collaborator

Signed-off-by: Chris Koch [email protected]

@codecov
Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #348 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
- Coverage   72.11%   71.95%   -0.16%     
==========================================
  Files          79       79              
  Lines        3998     3969      -29     
==========================================
- Hits         2883     2856      -27     
+ Misses        955      954       -1     
+ Partials      160      159       -1
Impacted Files Coverage Δ
dhcpv6/types.go 90% <ø> (ø) ⬆️
dhcpv6/option_iaprefix.go 88.57% <0%> (-1.43%) ⬇️
dhcpv6/option_prefixdelegation.go 100% <0%> (ø) ⬆️
dhcpv6/option_nontemporaryaddress.go 100% <0%> (ø) ⬆️
netboot/rtnetlink_linux.go 50% <0%> (ø) ⬆️
dhcpv6/option_iaaddress.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492d592...7209400. Read the comment docs.

Copy link
Collaborator

@pmazzini pmazzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hugelgupf
Copy link
Collaborator Author

Is go/tip broken?

@pmazzini
Copy link
Collaborator

pmazzini commented Jan 2, 2020

Is go/tip broken?

Yes, I think it is a golangci-lint issue: golangci/golangci-lint#896

Copy link
Owner

@insomniacslk insomniacslk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original names were coming from various RFCs, but I am OK with more readable names

@insomniacslk insomniacslk merged commit 53297fb into insomniacslk:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants