Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good old inline mode without HMR #263

Closed
bsideup opened this issue Feb 13, 2017 · 5 comments
Closed

Good old inline mode without HMR #263

bsideup opened this issue Feb 13, 2017 · 5 comments

Comments

@bsideup
Copy link

bsideup commented Feb 13, 2017

Hi!

This issue is a Feature request

I don't really like HMR because it fails with our app. Is it possible to use good old Webpack Dev Server + inline mode and disable HMR completely?

Thanks

@insin
Copy link
Owner

insin commented Feb 13, 2017

Yes, this is something which would be easy to flag off in the appropriate serve command(s) by only including the react-hmre preset if args.hmre isn't false, which would allow you to add a --no-hmre flag to your scripts to opt out.

@KatSick
Copy link

KatSick commented Mar 25, 2017

Is there any updates ? Have troubles with HMR in my app too. Is there any workaround i can apply right now ?

@insin insin closed this as completed in e829290 May 28, 2017
@KatSick
Copy link

KatSick commented Jun 15, 2017

@insin how to use --no-hmre with app.use(require('nwb/express')(express, { reload: true })); ?

i tried app.use(require('nwb/express')(express, { hmre: false })); but it not working

@insin insin reopened this Jun 15, 2017
@KatSick
Copy link

KatSick commented Jun 15, 2017

@insin i fix it with app.use(require('nwb/express')(express, { hmre: true, hmr: true, reload: true })); since i see in source code hmre: !options.hmr || !options.hmre, in expressMiddleware.

@insin
Copy link
Owner

insin commented Jun 15, 2017

Yeah, that's buggy -the next release should be coming soon, a fix for that logic will be included in it.

@insin insin closed this as completed in cd00a66 Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants