Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples on decorator vignette #1423

Merged

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Fixes comments on vignette example on #1357

@llrs-roche
Copy link
Contributor Author

Thank Marcin, but this doesn't fix all examples, specially the interactive-from lang issue as shown on the video from #1357 (comment) is not fixed. At least on my computer.

My current understanding is that at https://github.com/insightsengineering/teal/blob/1187_decorate_output%40main/R/module_transform_data.R#L96 the teal_data has already the new x_axis_title (on third or fourth pass), but how it got there and how to trigger it again when I change the input still eludes me.

@llrs-roche
Copy link
Contributor Author

Digging a b it deeper, I think that make_teal_transform_server() should have some kind of observe or binding to the input to ensure that when the input is updated the decorator is executed again. Otherwise it seems that it is only executed once

@llrs-roche llrs-roche marked this pull request as ready for review November 22, 2024 16:18
@llrs-roche llrs-roche merged commit 0a15929 into 1187_decorate_output@main Nov 22, 2024
1 check passed
@llrs-roche llrs-roche deleted the fix_examples@1187_decorate_output@main branch November 22, 2024 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants