Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teal.data::datanames() is deprecated in favor of dot-prefix and names() #324

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

@averissimo averissimo added the core label Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------------------------------------------------------
R/tm_g_gh_boxplot.R                        345      30  91.30%   362, 368, 507-508, 516-539, 541-542
R/tm_g_gh_correlationplot.R                566     566  0.00%    224-900
R/tm_g_gh_density_distribution_plot.R      272     272  0.00%    133-458
R/tm_g_gh_lineplot.R                       557     557  0.00%    159-810
R/tm_g_gh_scatterplot.R                    254     254  0.00%    142-450
R/tm_g_gh_spaghettiplot.R                  319     319  0.00%    192-594
R/toggleable_slider.R                      112       7  93.75%   140-146
R/utils-arbitrary_lines.r                  125      14  88.80%   62, 73-76, 80, 92-95, 109, 113, 120, 124
R/utils-data_constraints.r                 190      61  67.89%   39, 57, 111-124, 126-140, 154, 177, 183, 202-228, 243-252
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          66      17  74.24%   2-7, 39-42, 72-78
R/utils.R                                   49      40  18.37%   12-19, 26, 60-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2866    2148  25.05%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 879a848

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Unit Tests Summary

 1 files   1 suites   56s ⏱️
 6 tests  6 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit 879a848.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mentions of @env, @datanames, get_env() nor datanames() in the package.

@gogonzo gogonzo self-assigned this Nov 8, 2024
@gogonzo gogonzo merged commit 4063d5a into main Nov 8, 2024
29 checks passed
@gogonzo gogonzo deleted the 333_deprecate_datanames@main branch November 8, 2024 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants