Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup binary package repository for different platforms #8

Merged
merged 24 commits into from
Sep 26, 2024
Merged

Setup binary package repository for different platforms #8

merged 24 commits into from
Sep 26, 2024

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented Sep 23, 2024 •
edited
Loading

Use pkgcache::repo_resolve to dynamically set proper binary package repositories.

@walkowif walkowif requested review from pawelru and a team September 23, 2024 12:15
cicdguy
cicdguy reviewed Sep 24, 2024
View reviewed changes
action.yaml Outdated Show resolved Hide resolved
walkowif and others added 6 commits September 24, 2024 15:33
walkowif
walkowif commented Sep 25, 2024
View reviewed changes
action.yaml Outdated Show resolved Hide resolved
@walkowif walkowif mentioned this pull request Sep 25, 2024
Merged
pawelru
pawelru reviewed Sep 25, 2024
View reviewed changes
action.yaml Outdated Show resolved Hide resolved
pawelru
pawelru reviewed Sep 25, 2024
View reviewed changes
action.yaml Outdated Show resolved Hide resolved
@walkowif
fix: remove default_cran_mirror
8786283
@walkowif
Merge branch 'setup-binary-package-repository-for-different-platforms…
f9ff772 
…' of github.com:insightsengineering/setup-r-dependencies into setup-binary-package-repository-for-different-platforms
@walkowif
chore: remove debug step
64a4407
@pawelru
Copy link
Contributor

pawelru commented Sep 25, 2024

Code wise it's looking good now. I don't have any further comments.
I would have to check on the test results before the final approve.

@walkowif
Copy link
Contributor Author

Just in case, here are the latest pipelines where I was testing this:

  • R-hub workflow with repository-list: PPM@latest
  • R CMD check with repository-list: https://pharmaverse.r-universe.dev,PPM@latest

pawelru
pawelru reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@pawelru pawelru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I actually have one two more requests.

This is what I'm seeing:
image

  1. Can we make use of the ::group:: notation when printing the repos out
  2. Can we remove "Repositories written to ..." from the console output.

pawelru
pawelru reviewed Sep 25, 2024
View reviewed changes
action.yaml Outdated Show resolved Hide resolved
pawelru
pawelru reviewed Sep 25, 2024
View reviewed changes
action.yaml Outdated Show resolved Hide resolved
walkowif and others added 2 commits September 26, 2024 09:25
pawelru
pawelru approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍
Many thanks!

@walkowif walkowif merged commit 98df9df into main Sep 26, 2024
3 checks passed
@walkowif walkowif deleted the setup-binary-package-repository-for-different-platforms branch September 26, 2024 08:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cicdguy cicdguy cicdguy left review comments

@pawelru pawelru pawelru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walkowif @pawelru @cicdguy