Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths #5

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Fix paths #5

merged 6 commits into from
Sep 10, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Sep 9, 2024

  • support paths different than "." by adding "local::" prefix
  • other enhancements:
    • move check against empty lookup_refs into the step' if condition
    • remove extra-deps parameter - check lookup-refs against all dependencies allowing this parameter to take indirect dependencies
    • for feature branch match: loop through lookup-refs instead of direct deps
    • get the d object from path instead of dependency resolution

@pawelru pawelru requested a review from walkowif September 9, 2024 14:54
Copy link

github-actions bot commented Sep 10, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@walkowif
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@pawelru
Copy link
Contributor Author

pawelru commented Sep 10, 2024

I have read the CLA Document and I hereby sign the CLA

@pawelru pawelru merged commit 28659a6 into main Sep 10, 2024
3 checks passed
@pawelru pawelru deleted the fix_paths branch September 10, 2024 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants