-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide default to get_fields #19
Conversation
Signed-off-by: Lluís Revilla <[email protected]>
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
There is no script/bootstrap as indicated on the guidelines https://github.com/insightsengineering/.github/blob/b0a8ef47139d75c047a5b244911b5bf00491f7f8/CONTRIBUTING.md#submitting-a-pull-request If there is an easy way to test let me know. |
Hi @pawelru is there anything else to do to fix this? This is blocking the two linked PR. |
This PR was tested on teal, on a branch that was previously failing before: after the checks work and the workflow continues. It reports an error solving the dependency but later it solves the dependencies, as expected, and continues with all the steps:
@cicdguy, can you please make a release for this once merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thank you!
This patch was proposed by Pawel to fix issues like https://github.com/insightsengineering/teal/actions/runs/11794622576/job/32853793903?pr=1406 and https://github.com/insightsengineering/teal/actions/runs/11794595252/job/32852528908?pr=1357 where the message is:
Simple reproducible code:
I also added a default on line 165 not originally proposed but I think could avoid this problem in other circumstances.
Not tested (yet) as I'm editing directly from github.