Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add *.md for lychee link checks #240

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: Add *.md for lychee link checks #240

merged 1 commit into from
Jun 5, 2024

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Jun 5, 2024

Bug discovery credit goes to @gowerc

@cicdguy cicdguy self-assigned this Jun 5, 2024
@cicdguy cicdguy requested a review from a team as a code owner June 5, 2024 15:25
Copy link
Contributor

github-actions bot commented Jun 5, 2024

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 72ec2c9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit 72ec2c9.

@cicdguy cicdguy merged commit 678bbe0 into main Jun 5, 2024
26 checks passed
@cicdguy cicdguy deleted the cicdguy-patch-2 branch June 5, 2024 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@gowerc
Copy link

gowerc commented Jun 5, 2024

I appreciate this has already been merged but is it worth adding *.Rmd and *.yml for the README.Rmd file and other arbitrary yaml config files ?

@cicdguy
Copy link
Contributor Author

cicdguy commented Jun 5, 2024

I appreciate this has already been merged but is it worth adding *.Rmd and *.yml for the README.Rmd file and other arbitrary yaml config files ?

I was contemplating this but any root-level Rmd files or YAML configs in an R package are uncommon. We can add them on a case by case basis or even add an explicit option to include more file patterns.

My bigger concern is that lychee need to support more standard globbing patterns. We'll follow up with them on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants